Skip to content

Enforce error handling for promises and improve command execution - #73

Merged
TamasBoncz merged 2 commits into
mainfrom
fix/21-promote-no-floating-promises-no-unsafe-to-error
May 29, 2026
Merged

TamasBoncz merged 2 commits into
mainfrom
fix/21-promote-no-floating-promises-no-unsafe-to-error

Conversation

@TamasBoncz

@TamasBoncz TamasBoncz commented May 27, 2026

Copy link
Copy Markdown
Collaborator

This pull request strengthens code quality by tightening linting rules and improves codebase robustness by ensuring that all asynchronous calls are properly handled. The main changes are grouped below:

resolves #21

Linting Rule Updates

  • Upgraded several @typescript-eslint rules (such as no-floating-promises, no-misused-promises, and others) and import-x/no-duplicates from "warn" to "error", making violations fail the lint step instead of just warning. This enforces stricter code safety and import hygiene. [1] [2]

Asynchronous Call Handling

  • Added void before calls to vscode.window.showErrorMessage, vscode.window.showInformationMessage, vscode.commands.executeCommand, and other promise-returning functions to explicitly ignore returned promises, preventing unhandled promise rejections and satisfying stricter linting. [1] [2] [3] [4] [5] [6] [7]

Test Import Cleanup

  • Cleaned up imports in parser-shared.test.ts by combining multiple import statements into a single line for clarity.## Description

Related Issues

Checklist

  • npm run check passes (typecheck + lint + spellcheck + knip + tests)
  • Changes are covered by tests (if applicable)
  • Documentation updated (if applicable)

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@TamasBoncz

Copy link
Copy Markdown
Collaborator Author

@microsoft-github-policy-service agree

@TamasBoncz
TamasBoncz merged commit 3a41450 into main May 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants